Skip to content

Derive Default for enums #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Derive Default for enums #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions wp_api/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,19 +323,14 @@ impl WPApiHelper {
}
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
pub enum WPContext {
Edit,
Embed,
#[default]
View,
}

impl Default for WPContext {
fn default() -> Self {
Self::View
}
}

impl WPContext {
fn as_str(&self) -> &str {
match self {
Expand Down Expand Up @@ -370,18 +365,13 @@ pub enum RequestMethod {
HEAD,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
pub enum WPApiParamOrder {
#[default]
Asc,
Desc,
}

impl Default for WPApiParamOrder {
fn default() -> Self {
Self::Asc
}
}

impl WPApiParamOrder {
fn as_str(&self) -> &str {
match self {
Expand Down
18 changes: 4 additions & 14 deletions wp_api/src/users.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ add_uniffi_exported_parser!(
);
add_uniffi_exported_parser!(parse_delete_user_response, UserDeleteResponse);

#[derive(Debug, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
pub enum WPApiParamUsersOrderBy {
Id,
Include,
#[default]
Name,
RegisteredDate,
Slug,
Expand All @@ -48,12 +49,6 @@ pub enum WPApiParamUsersOrderBy {
Url,
}

impl Default for WPApiParamUsersOrderBy {
fn default() -> Self {
Self::Name
}
}

impl WPApiParamUsersOrderBy {
fn as_str(&self) -> &str {
match self {
Expand All @@ -69,8 +64,9 @@ impl WPApiParamUsersOrderBy {
}
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, uniffi::Enum)]
pub enum WPApiParamUsersWho {
#[default]
All,
Authors,
}
Expand All @@ -85,12 +81,6 @@ impl WPApiParamUsersWho {
}
}

impl Default for WPApiParamUsersWho {
fn default() -> Self {
Self::All
}
}

#[derive(Debug, Default, uniffi::Record)]
pub struct UserListParams {
/// Current page of the collection.
Expand Down