Skip to content

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented May 23, 2024

  • Moves parse_wp_response, parse_response_for_generic_errors functions and add_uniffi_exported_parser macro to WPNetworkResponse
  • Adds a parse_with function to replace WPNetworkResponseParser trait
  • Replaces String::from_utf8_lossy(&response.body).to_string() with body_as_string introduced in All public types implement Debug trait #109
  • Moves RequestMethod enum to request module in 7b1bffa

I might do further improvements to this setup, but to keep the PR simple, this is mostly just moving things around.

@oguzkocer oguzkocer added the Rust label May 23, 2024
@oguzkocer oguzkocer added this to the 0.1 milestone May 23, 2024
@oguzkocer oguzkocer requested review from crazytonyli and jkmassel May 23, 2024 21:06
@jkmassel jkmassel enabled auto-merge (squash) May 23, 2024 21:14
@jkmassel jkmassel force-pushed the move-parser-to-wp-response branch from 2b20046 to 3acc722 Compare May 23, 2024 21:57
@jkmassel jkmassel merged commit 69fcbac into trunk May 23, 2024
@jkmassel jkmassel deleted the move-parser-to-wp-response branch May 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants