Add a CI step to validate CocoaPods support #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazytonyli
force-pushed
the
cocoapods-support
branch
from
3dc5296 to
bc2265e
Compare
crazytonyli
changed the title
jkmassel
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see the need of supporting CocoaPods at the moment. But just in case the requirement arises, this PR adds a simple step to validate we can support CocoaPods.
To fully support CocoaPods, we need to tweak our releases flow to create a source archive, and put it in a HTTP server (i.e. our S3 public artifactory bucket). That of course involves changing the release process.
Also, one major difference between the Swift package and pods is we have two modules
WordPressAPIandWordPressAPIInternalin the Swift package, whereas we'll only have oneWordPressAPIin CocoaPods. Thus, technically, their public API is different.