Support the plugins endpoint in the Swift package #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
requested changes
May 27, 2024
| // MARK: - Convenience Methods | ||
|
|
||
| public extension AnyNamespace where T == SparsePlugin { | ||
| func install(slug: PluginWpOrgDirectorySlug, status: PluginStatus) async throws -> PluginWithEditContext { |
There was a problem hiding this comment.
Can we do install, activate, deactivate, and uninstall (or delete)?
There was a problem hiding this comment.
I have added activate and deactivate. uninstall is already implemented in the function below.
BTW, just to be super clear, these convenience methods co-exist with the create/update/delete functions. They just provide more appropriate semantic in the context of plugins than the REST verbs.
jkmassel
approved these changes
May 27, 2024
jkmassel
force-pushed
the
swift-package-plugin
branch
from
802b8f8 to
773e24a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What says in the title.
This PR adds
installanduninstallmethods, which are more appropriate in the context of plugins, as alternatives toapi.plugins.create(...)anddelete.