Add Link Header Tests #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
reviewed
May 27, 2024
wp_api/Cargo.toml
Outdated
|
|
||
| [dev-dependencies] | ||
| chrono = { version = "0.4" } | ||
| claim = "0.5" |
There was a problem hiding this comment.
It's probably not worth adding a dependency just for assert_none which can be done with .is_none().
wp_api/src/request.rs
Outdated
Comment on lines
171
to
204
| #[test] | ||
| fn test_link_header_can_be_parsed_for_first_page() { | ||
| let response = WPNetworkResponse{ body: Vec::with_capacity(0), status_code: 200, header_map: Some(HashMap::from([("Link".to_string(), "<http://localhost/wp-json/wp/v2/posts?page=2>; rel=\"next\"".to_string())])) }; | ||
| assert_eq!(response.get_link_header("next").unwrap(), Url::parse("http://localhost/wp-json/wp/v2/posts?page=2").unwrap()); | ||
| assert_none!(response.get_link_header("prev")); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_link_header_can_be_parsed_for_intermediate_pages() { | ||
| let response = WPNetworkResponse{ body: Vec::with_capacity(0), status_code: 200, header_map: Some(HashMap::from([("Link".to_string(), "<http://localhost/wp-json/wp/v2/posts?page=1>; rel=\"prev\", <http://localhost/wp-json/wp/v2/posts?page=3>; rel=\"next\"".to_string())])) }; | ||
| assert_eq!(response.get_link_header("prev").unwrap(), Url::parse("http://localhost/wp-json/wp/v2/posts?page=1").unwrap()); | ||
| assert_eq!(response.get_link_header("next").unwrap(), Url::parse("http://localhost/wp-json/wp/v2/posts?page=3").unwrap()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_link_header_can_be_parsed_for_last_page() { | ||
| let response = WPNetworkResponse{ body: Vec::with_capacity(0), status_code: 200, header_map: Some(HashMap::from([("Link".to_string(), "<http://localhost/wp-json/wp/v2/posts?page=5>; rel=\"prev\"".to_string())])) }; | ||
| assert_none!(response.get_link_header("next")); | ||
| assert_eq!(response.get_link_header("prev").unwrap(), Url::parse("http://localhost/wp-json/wp/v2/posts?page=5").unwrap()); | ||
| } |
There was a problem hiding this comment.
I think these tests can be written in a much nicer way with rstest that'll allow us to add more cases without having to copy/paste the implementation.
Since there were some syntax suggestions as well, I combined all of them into a suggestion commit: 53e7072. Let me know what you think!
jkmassel
force-pushed
the
add/link-header-tests
branch
2 times, most recently
from
141b035 to
81d80cb
Compare
oguzkocer
approved these changes
May 29, 2024
oguzkocer
force-pushed
the
add/link-header-tests
branch
from
81d80cb to
f50c3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for #119 – the code works correctly, and this does overlap with what the Link Header Parser's test suite should do, but now that we're re-mapping the output in a more efficient way I figure it'd be nice to be able to quickly ensure that it's working.
To Test: