Rename upper case abbreviations to camel case #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
force-pushed
the
rename-upper-case-abbreviations-to-camel-case
branch
from
f065e7f to
e5d139e
Compare
jkmassel
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate Swift & Kotlin bindings, all type names get renamed as camel case. This creates a disconnect between the types names in Rust & native bindings. This PR addresses that by using camel case everywhere, removing upper case abbreviations - in most cases renaming
WPasWp.The PR is split into commits to make it easier to review. I'd normally squash these to 1-2 commits when I am done, but they will get squashed into a single commit once the PR is merged, so I am leaving them as is.
Note that the only breaking change for the native implementation was related to the type names in the
loginmodule. This is because the type names in that module went beyond abbreviations and used upper case words. All of that was addressed in a single commit: e5d139e.