Revert "Use http::HeaderMap to store response headers" #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bef8433.
jkmassel
approved these changes
Jun 4, 2024
|
👍 No worries. I haven't looked at your async trait PR yet, but I wonder if we can reproduce and catch this issue in unit tests, so that it doesn't accidentally reappear in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #132.
Unfortunately using
uniffi::Objectfor the response completely breaks the using asynchronous trait to execute requests approach that I am working on. I'd like to revert this for now and then re-visit it once I am done with my changes. We can handle the header parsing issue in a later layer if necessary.Sorry about that @crazytonyli!