[Swift] Fix the Example app #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
Jun 5, 2024
| self.fetchUsersTask = Task { @MainActor in | ||
| do { | ||
| users = try await api.users.forViewing.list() | ||
| users = try await api.users.listWithViewContext(params: nil) |
There was a problem hiding this comment.
Not necessarily for this PR, but are we able to make it so we can just call this like try await api.users.listWithViewContext() and provide params if needed?
There was a problem hiding this comment.
Agreed. That's implemented in the old API design where we had generic types to check if the params argument is Optional. I'll look into it later, potentially together with providing a better API regarding handling the new RequestExecutionError type.
There was a problem hiding this comment.
Or, we can just implement a few listWith[View|Edit|Embed]Context() functions to Swift, if we can't have a general solution in short term.
jkmassel
force-pushed
the
request-executor-swift-package
branch
from
c87af46 to
5fc35fe
Compare
|
I also rebased this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is built on top of #136
This PR also adds a
SafeRequestExecutortype to avoid accidentally throwing random error instances into Rust code, which would cause crash (discussed in #136 (comment)).