Skip to content

Conversation

oguzkocer
Copy link
Contributor

Adds List variant of /application_passwords using the new #[derive(WpDerivedRequest)]. It adds unit tests to validate the generated list & filter_list endpoint urls and integration tests to validate list & filter_list request executor implementations.

Note that there are some minor inconveniences in this PR, specifically related to how the ApplicationPasswordsRequestExecutor is built. These will be addressed once the changes from WpDerivedRequest is complete.


To Test

  • make test-server && make dump-mysql && make backup-wp-content-plugins
  • cargo test --test '*' -- --test-threads 1

@oguzkocer oguzkocer added this to the 0.1 milestone Jun 21, 2024
@oguzkocer oguzkocer requested a review from jkmassel June 21, 2024 05:04
@oguzkocer oguzkocer enabled auto-merge (squash) June 21, 2024 05:04
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed via Slack - needs one followup to address idents – to come later.

@oguzkocer oguzkocer merged commit e7776a8 into trunk Jun 25, 2024
@oguzkocer oguzkocer deleted the application-passwords branch June 25, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants