Skip to content

Conversation

oguzkocer
Copy link
Contributor

Removes the manual endpoint & request builder implementation for /plugins in favor of the derived implementation from #[derive(WpDerivedRequest)].

Updates WpDerivedRequest to generate the functions to accept &Foo instead Foo in the given "/foo/<bar>" url input.


To Test

  • make test-server && make dump-mysql && make backup-wp-content-plugins
  • cargo test --test '*' -- --test-threads 1

@oguzkocer oguzkocer added this to the 0.1 milestone Jun 21, 2024
@oguzkocer oguzkocer requested a review from jkmassel June 21, 2024 16:47
@jkmassel jkmassel force-pushed the users-from-derived-request branch from 3b0dccf to 2e800a2 Compare June 25, 2024 18:59
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in sync call – this is a very simple change that mostly just removes hand-copied code

@oguzkocer oguzkocer force-pushed the plugins-from-derived-request branch from d4c573f to 151d71b Compare June 25, 2024 19:08
@jkmassel jkmassel force-pushed the plugins-from-derived-request branch from 151d71b to 34390b6 Compare June 25, 2024 19:10
Base automatically changed from users-from-derived-request to trunk June 25, 2024 19:24
@jkmassel jkmassel force-pushed the plugins-from-derived-request branch from 34390b6 to 415dee9 Compare June 25, 2024 19:25
@jkmassel jkmassel enabled auto-merge (squash) June 25, 2024 19:26
@jkmassel jkmassel merged commit 28d14e8 into trunk Jun 25, 2024
@jkmassel jkmassel deleted the plugins-from-derived-request branch June 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants