Wrapping up the immediate changes for #[derive(WpDerivedRequest)]
#158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up the immediate work related to
#[derive(WpDerivedRequest)]
and includes miscellaneous changes:2
suffix from request builder types we temporarily used during the transition.RequestBuilder
type to remove request execution and renames it asInnerRequestBuilder
to make it easier to separate from the generated types such asUsersRequestBuilder
.WpDerivedRequest
to make it easier to work with.UsersRequestBuilder
to pass it intoUsersRequestExecutor
's constructor, but now we pass the arguments required to buildUsersRequestBuilder
instead.WpAuthentication
instead ofInnerRequestBuilder
and builds the inner type itself. This comes at a tiny additional memory cost, however it improves the function signature and some of the extra restrictions.pub