Change WpNetworkRequest to be derived from uniffi::Object
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
force-pushed
the
wp-network-request-as-uniffi-object
branch
from
0d8eb72 to
1791df3
Compare
jkmassel
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Integrated nicely with Swift.
I asked @oguzkocer on Slack if we should have toFlatMap be in the Rust layer, not Swift, but for now we're happy to leave it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
WpNetworkRequestto be derived fromuniffi::Objectand starts usingWpNetworkHeaderMapinternally as opposed to the priorHashMap. It also introducesWpNetworkRequestBody, which at the moment is just a wrapper aroundVec<u8>and shares its contents by cloning it. In the future, we might switch it to use interior mutability to give up ownership of the contents instead.Adds
WpNetworkHeaderMap::to_mapso that the Kotlin & Swift wrappers can build the headers from it.To Test
make test-server && make dump-mysql && make backup-wp-content-pluginscargo test --test '*' -- --test-threads 1cd native/kotlin && ./gradlew :api:kotlin:integrationTest