Add URLSession helpers to send request and parse response #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #42 – once it lands, we'll need to rebase this PR and can meaningfully review it in the context of Linux / Darwin compatibility |
|
I have turned this PR to draft, because there are some additional work needed regarding Linux support. |
crazytonyli
force-pushed
the
add-url-session-helpers
branch
from
79ecf42 to
81e08fd
Compare
OHHTTPStubs can't be compiled on Linux because it depends on the Objective-C Foundation framework, which is not available on Linux.
crazytonyli
force-pushed
the
add-url-session-helpers
branch
from
81e08fd to
d4499fc
Compare
crazytonyli
force-pushed
the
add-url-session-helpers
branch
from
317db2c to
3a90947
Compare
|
Closing this PR as none of the changes are really needed at the moment. The progress tracking might be useful, but we can bring that into the trunk branch when it's needed by the apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a URLSession helper function to send requests, including their body, which is not possible for now because
WPNetworkRequestdon't have abodyproperty yet.Background URLSession
Due to the constraint on background URLSession instances where they can only get HTTP responses via
URLSessionDelegate(thedataTask(for:completionHandler:)and similar APIs would simply crash), we have to implement a custom delegate to get them work with ourasyncor closure-based APIs. This should work fine for now, but if in the future we want to accept background URLSession instances created by the clients, we should rethink this specialURLSessionDelegateimplementation.Error handling
This PR only includes a very light error handling. And the API-level (i.e. parsing
codeandmessagefrom .org REST API response) error handling will wait once we have a solution on #22.