Skip to content

Conversation

oguzkocer
Copy link
Contributor

Changes the file format of test_credentials to:

{site_url}
{username}
{token}

Updates the .buildkite/setup-test-site.sh to add the site_url & email address to test_credentials file.

You can run make test-server && cargo run to test the changes.


We want to add a new variant to WPAuthentication for username & token. I think we'll also want to change the AuthorizationHeader name as it's not descriptive enough. These changes would be breaking, so I am leaving them to a separate PR.


Note that this PR is built on #58 and should be merged after it's merged to trunk. Although there is nothing in this PR related to users, this will keep

@oguzkocer oguzkocer added this to the 0.1 milestone Apr 8, 2024
@oguzkocer oguzkocer requested a review from crazytonyli April 8, 2024 17:50
@oguzkocer oguzkocer requested a review from jkmassel April 8, 2024 17:50
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests still work fine, so should be all good

Base automatically changed from users_types to trunk April 12, 2024 17:56
@oguzkocer oguzkocer marked this pull request as ready for review April 12, 2024 18:01
@oguzkocer oguzkocer enabled auto-merge (squash) April 12, 2024 18:01
@oguzkocer oguzkocer merged commit f0cdd90 into trunk Apr 12, 2024
@oguzkocer oguzkocer deleted the update/test_credentials_format branch April 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants