Skip to content

Conversation

oguzkocer
Copy link
Contributor

// before
https://foo.com/wp-json/wp/v2/users?context=edit&slug=&roles=&capabilities=
// after
https://foo.com/wp-json/wp/v2/users?context=edit`

@oguzkocer oguzkocer added the Rust label Apr 12, 2024
@oguzkocer oguzkocer added this to the 0.1 milestone Apr 12, 2024
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but this seems like a good candidate for a unit test to me.

WDYT?

@oguzkocer
Copy link
Contributor Author

@jkmassel I'll work on the unit tests for the users module in its own PR.

@oguzkocer oguzkocer merged commit 10f6163 into trunk Apr 12, 2024
@oguzkocer oguzkocer deleted the dont-include-empty-vecs-in-user-list-params branch April 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants