Add Detekt #83
Merged
Add Detekt #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
force-pushed
the
add/detekt
branch
3 times, most recently
from
c231879 to
9fde65c
Compare
wzieba
approved these changes
May 14, 2024
Comment on lines
+93
to
+100
| echo "--- :rust: Installing Rust" | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -v -y | ||
| source "$$HOME/.cargo/env" | ||
| echo "--- :package: Installing Rust Toolchains" | ||
| make setup-rust | ||
| make setup-rust-android-targets |
There was a problem hiding this comment.
Maybe this could be a separate step? If I was debugging it, I wouldn't expect Detekt step to install Rust dependencies.
There was a problem hiding this comment.
This is here because it's necessary for the project to build at the moment. I agree that it's not ideal and I'll see if I can get rid of that requirement when I can - but for now, having these extra steps is not a big deal.
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15.
detektMain&detektTesttasks. I picked these over thedetekttask because they include the new type resolution feature.wp_api.kt. I tried to do this in a way where we could exclude all source code underbuild/generated/source, but couldn't get that to work. I also tried using thedetekt.ymlconfig file to do the same, but I could only do it per rule and couldn't get theexcludesattribute to work for this file.