Skip to content

Conversation

oguzkocer
Copy link
Contributor

Extracts a few helper functions that we use in tests to common modules, so we can access them for new features. It also drops the ApiBaseUrl argument from the validate_endpoint function and uses the exported fixture to remove a lot of boilerplate.

@oguzkocer oguzkocer added this to the 0.1 milestone May 15, 2024
@oguzkocer oguzkocer requested review from crazytonyli and jkmassel May 15, 2024 21:00
@oguzkocer oguzkocer enabled auto-merge (squash) May 15, 2024 21:01

#[fixture]
pub fn fixture_api_base_url() -> ApiBaseUrl {
ApiBaseUrl::new("https://foo.com").unwrap()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we use example.com, which is designed for this sort of thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #89.

@oguzkocer oguzkocer merged commit 089c84b into trunk May 15, 2024
@oguzkocer oguzkocer deleted the extract-test-helpers branch May 15, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants