/navigation endpoint
#941
Merged
/navigation endpoint
#941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
Oct 3, 2025
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
I tested this and it works fine.
The enum wrappers for title and content are a bit weird, but it's workable. I think having these post params be optional make a lot of sense in the context of custom post types, so I think this approach works.
I'm good to move forward with it if you are.
Contributor
Author
@jkmassel As mentioned in the PR description, we won't actually use the types in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows established patterns to implement
/navigationendpoint.I initially implemented it as a separate endpoint, but then @jkmassel and I discussed it and decided to make it a
PostEndpointType. We do lose a bit static type information with this approach, so I kept the original implementation as well, so we can decide in this PR whether to keep thePostEndpointTypeapproach or use a separate endpoint. Either way, I think it's good to have both approaches in the git history to be able to revert our decision if we regret it.I haven't implemented Kotlin integration tests yet as I'd like to make this ^ decision first.