Fix support bot response parsing #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new serde helper that specifically handles the case where a field can be either an empty array or a valid object. This is more type-safe than ok_or_default as it only handles the specific empty array case and still propagates legitimate deserialization errors. Changes: - Add `DeserializeEmptyVecOrNone` visitor and `deserialize_empty_vec_or_none` helper - Replace `ok_or_default` usage in `UserMessageContext.plan` field - Helper properly deserializes `T` and wraps in `Some`, or returns `None` for empty arrays
oguzkocer
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support bot responses had some unexpected format differences between responses, so I'm properly handling these now.