Remove the need for the wpcli container #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
remove/wpcli-container
branch
2 times, most recently
from
b82ea5e to
9ea1a41
Compare
jkmassel
force-pushed
the
remove/wpcli-container
branch
from
9ea1a41 to
2f19b70
Compare
oguzkocer
reviewed
May 21, 2024
Co-authored-by: Oguz Kocer <oguzkocer@users.noreply.github.com>
oguzkocer
approved these changes
May 21, 2024
There was a problem hiding this comment.
Tested with the below command and the integration tests worked as expected. The weird issue with installed plugins not showing up and the errors in wp-admin/plugins are also gone. Thanks a lot for addressing the issues @jkmassel! 🙇♂️
make test-server && make dump-mysql && make backup-wp-content-plugins
cargo test --test '*' -- --nocapture --test-threads 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.