Skip to content

Remove custom parser in favor of AST parser #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Remove custom parser in favor of AST parser #13

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5227c4c
Remove custom parser in favor of AST parser
sejas Oct 8, 2025
84a3a8d
Add try catch instead of checking $result false value
sejas Oct 8, 2025
6fe2f55
Add semi colon to comments regex
sejas Oct 8, 2025
79063a8
Add support for old driver WP_SQLite_Translator
sejas Oct 8, 2025
e7e8570
Update comments
sejas Oct 8, 2025
ca2f090
Bypass SET comments instead of removing all the comments
sejas Oct 8, 2025
b58afac
Fix comment indentation
sejas Oct 8, 2025
d897a9e
Fix file encoding like: https://github.com/WordPress/sqlite-database-…
sejas Oct 8, 2025
fdf1b63
Echo the skipped comments instead of using a wp-cli warning to reduce…
sejas Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion src/Import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ public function run( $sql_file_path, $args ) {
$is_stdin = '-' === $sql_file_path;
$import_file = $is_stdin ? 'php://stdin' : $sql_file_path;

$this->execute_statements( $import_file );
if ( method_exists( $this->driver, 'create_parser' ) ) {
$this->execute_statements_with_ast_parser( $import_file );
} else {
$this->execute_statements( $import_file );
}

$imported_from = $is_stdin ? 'STDIN' : $sql_file_path;
WP_CLI::success( sprintf( "Imported from '%s'.", $imported_from ) );
Expand Down Expand Up @@ -133,4 +137,39 @@ public function parse_statements( $sql_file_path ) {

fclose( $handle );
}

/**
* Execute SQL statements from an SQL dump file using the AST parser.
*
* @param $import_file
*
* @return void
* @throws Exception
*/
protected function execute_statements_with_ast_parser( $import_file ) {
$raw_queries = file_get_contents( $import_file );

// Detect and convert encoding to UTF-8
$detected_encoding = mb_detect_encoding( $raw_queries, mb_list_encodings(), true );
if ( $detected_encoding && 'UTF-8' !== $detected_encoding ) {
$raw_queries = mb_convert_encoding( $raw_queries, 'UTF-8', $detected_encoding );
}

$parser = $this->driver->create_parser( $raw_queries );
while ( $parser->next_query() ) {
$ast = $parser->get_query_ast();
$statement = substr( $raw_queries, $ast->get_start(), $ast->get_length() );
try {
$this->driver->query( $statement );
} catch ( Exception $e ) {
// Skip errors when executing SET comment statements
if ( 0 === strpos( $statement, 'SET ' ) && false !== strpos( $statement, '*/' ) ) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot use str_starts_with or str_contains because we support PHP 7.4

echo 'Warning - SQLite import skipped SET comment statement: ' . $statement . PHP_EOL;
continue;
}
WP_CLI::error( 'SQLite import could not execute statement: ' . $statement );
echo $this->driver->get_error_message();
}
}
}
}