Skip to content

Conversation

sejas
Copy link
Member

@sejas sejas commented Oct 14, 2025

Proposed changes

  • Pass the error when a query is in UTF-8 format and fails to run the import.

Testing steps

  • Apply this change to Studio server files: ~/Library/Application Support/Studio/server-files/sqlite-command/src/Import.php
  • Start Studio
  • Go to the import tab
  • Drag and drop a SQL malformed fake.sql
  • Observe the error in Studio
Screenshot 2025-10-14 at 14 54 39

@sejas sejas self-assigned this Oct 14, 2025
@sejas sejas requested a review from a team October 14, 2025 14:05
Copy link

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas for the prompt fix! I have tested it, and it works as advertised, I can see the validation error as expected. LGTM! :shipit:

Image

@sejas sejas merged commit 90ddb8d into main Oct 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants