Skip to content

Fix a problem where currencyId is not set on Turing chains #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fix a problem where currencyId is not set on Turing chains #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3cb91
Fix a problem where currencyId is not set on Turing chains
chrisli30 Dec 17, 2023
fed93dc
docs(changeset): Fix a problem where currencyId is not set on Turing …
chrisli30 Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-lizards-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@oak-network/config": patch
---

Fix a problem where currencyId is not set on Turing chains
4 changes: 3 additions & 1 deletion packages/config/src/tokens/types/XToken.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Token, TokenConstructorParams } from "./Token"; // Ensure this path is

interface XTokenConstructorParams {
asset: TokenConstructorParams; // The 'asset' property is introduced here.
id?: number;
isNative: boolean;
contractAddress?: string;
otherSymbol?: string;
Expand All @@ -13,7 +14,7 @@ interface XTokenConstructorParams {
}

class XToken extends Token {
public id: any; // Consider specifying a more precise type if possible.
public id: number | undefined;

public isNative: boolean;

Expand All @@ -29,6 +30,7 @@ class XToken extends Token {
// Spreading 'asset' properties here so that they are passed as individual parameters to the super constructor.
super({ ...params.asset });

this.id = params.id;
this.isNative = params.isNative;
this.contractAddress = params.contractAddress;
this.otherSymbol = params.otherSymbol;
Expand Down