Skip to content

Conversation

@drvinceknight
Copy link
Member

@drvinceknight drvinceknight commented May 31, 2016

Just testing if #600 is fixed.

@coveralls
Copy link

coveralls commented May 31, 2016

Coverage Status

Coverage remained the same at 99.726% when pulling 634a670 on 600 into 7b8b470 on master.

@meatballs
Copy link
Member

At last!

@meatballs
Copy link
Member

The rounding seems to have worked too. No more failures for reducing coverage by 0.001%

@drvinceknight
Copy link
Member Author

At last!

So it doesn't look to be integrated like it used to to me?

The comment on the PR is new: I guess that was that checkbox? But it's not coming up as an integrated test like it used to "2 successful checks" as opposed to 3 (https://www.dropbox.com/s/kaxy9nvql1go3n9/Screenshot%202016-05-31%2010.27.01.png?dl=0)...

Because you've set up coveralls do you perhaps need to authorise it with github here: https://github.com/integrations/coveralls This is what I see there: https://www.dropbox.com/s/59le1twd1tkpj7r/Screenshot%202016-05-31%2010.26.31.png?dl=0

@meatballs
Copy link
Member

woo hoo!

@drvinceknight
Copy link
Member Author

woo hoo!

Sweet! :) 👍

@coveralls
Copy link

coveralls commented May 31, 2016

Coverage Status

Changes Unknown when pulling 689f34a on 600 into * on master*.

@drvinceknight
Copy link
Member Author

Closes #600

@drvinceknight drvinceknight deleted the 600 branch May 31, 2016 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants