Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

feat(icons): added new icons #255

Merged
merged 1 commit into from
Feb 10, 2023
Merged

feat(icons): added new icons #255

merged 1 commit into from
Feb 10, 2023

Conversation

@danlundgren1
Copy link

@danlundgren1 danlundgren1 commented Feb 7, 2023 •
edited
Loading

Added new icons

Checklist before requesting a review

  • I have performed a self-review of my own code
  • [ X ] I have verified that the code builds perfectly fine on my local system
  • [ / ] I have added tests that prove my fix is effective or that my feature works
  • [ / ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have verified that my code follows the style already available in the repository
  • [ / ] I have made corresponding changes to the documentation

@danlundgren1 danlundgren1 requested a review from Tigge as a code owner February 7, 2023 12:33
@lekoaf
Copy link
Member

lekoaf commented Feb 7, 2023

@danlundgren1, don't add internal links on an external package...

@danlundgren1
Copy link
Author

danlundgren1 commented Feb 7, 2023

@danlundgren1, don't add internal links on an external package...

Fixed

@lekoaf lekoaf requested a review from boilund February 8, 2023 09:44
@boilund
Copy link
Collaborator

boilund commented Feb 8, 2023

We use conventional commit so please edit your commit message to feat(icons): added ICON_NAME icon.

@danlundgren1 danlundgren1 force-pushed the danlu/feat/ndsfw-4303 branch from 98a6fcb to 84f2a11 Compare February 8, 2023 10:12
@danlundgren1 danlundgren1 changed the title added new icons feat(icons): added new icons Feb 8, 2023
boilund
boilund reviewed Feb 8, 2023
View reviewed changes
@danlundgren1 danlundgren1 force-pushed the danlu/feat/ndsfw-4303 branch from 84f2a11 to d5c2080 Compare February 8, 2023 14:01
boilund
boilund approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@boilund boilund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danlundgren1 danlundgren1 force-pushed the danlu/feat/ndsfw-4303 branch from d5c2080 to e151005 Compare February 9, 2023 08:55
@Tigge Tigge merged commit e3c73dc into AxisCommunications:main Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tigge Tigge Awaiting requested review from Tigge Tigge is a code owner

1 more reviewer

@boilund boilund boilund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danlundgren1 @lekoaf @boilund @Tigge