Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Conversation

@Sana-Shana
Copy link
Contributor

@Sana-Shana Sana-Shana commented Feb 10, 2023

Describe your changes

Fix transition animation for expandable components in development.
Set only the initial offsetHeight of html elements for increaseHeight,
because in development when react runs in strict mode, the height of the component is set twice.

Also, create a bug report

Fixes #256

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@Sana-Shana Sana-Shana requested a review from Tigge as a code owner February 10, 2023 15:32
@boilund
Copy link
Collaborator

boilund commented Feb 17, 2023

Please replace the ticket link with the issue in this repo in your commit message, like "Fixes: #256".

@Sana-Shana Sana-Shana changed the title fix(transition): transition to expand component in development fix(transition): transition to expand component in development #256 Feb 17, 2023
@Sana-Shana Sana-Shana changed the title fix(transition): transition to expand component in development #256 fix(transition): transition to expand component in development Feb 17, 2023
fix transition to avoid running the increaseHeight twice in development.

Fixes: AxisCommunications#256
@Sana-Shana Sana-Shana force-pushed the 3506-transition-animation branch from 9a3c722 to 3eb1295 Compare February 17, 2023 14:01
@Sana-Shana Sana-Shana requested review from boilund and removed request for Tigge February 17, 2023 14:02
@boilund boilund merged commit abd8f10 into AxisCommunications:main Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition for expandable components doesn't work in proper way in development.

2 participants