Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Conversation

@tripleWdotcom
Copy link
Contributor

@tripleWdotcom tripleWdotcom commented Jun 8, 2021

I changed some props from Card documentation example code in order to have the correct code in the example. Fixes #98

I also added states to Switch and TextInputField components to give a little more interaction to the Demo:

2021-06-09.19-01-25.mp4

Copy link
Member

@lekoaf lekoaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boilund
Copy link
Collaborator

boilund commented Jun 16, 2021

Looks good. Could you add link to the issue in your commit message and in description in this PR (ex. Fixes #XX)

@Tigge
Copy link
Collaborator

Tigge commented Jun 22, 2021

I recommend using https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword to close the issue automatically.

I.e. write Fixes #98 in the commit message body.

@Tigge Tigge merged commit 8a365c3 into AxisCommunications:main Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card has a small error in the documentation

4 participants