Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 26, 2022

Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb added this to the Release 4.6.0 milestone Sep 27, 2022
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of remarks here.

@smcvb smcvb changed the title Updated not working code samples Update Dead-Letter Queue Code samples Sep 27, 2022
smcvb and others added 18 commits October 6, 2022 16:08
Add AF 4.6.1 release notes
Add Multi-Tenancy extesions 4.6.1 release notes
Add Tracing extesions 4.6.1 release notes
Add JGroups and MultiTenancy minor release link to summary
workerExecutor

(cherry picked from commit 84913ee)
Append RevisionSnapshotFilter description to the Filtering
Snapshot Events section. This should further clarify that all a user has
 to do to enable revision-based snapshot filtering, is add the @revision
 annotation.

#enhancement/revision-snapshot-filter
Add a notice stating why Sagas do not support the DLQ.

#enhancement/saga-dlq-notice
Introduce a dedicated token stealing section onto to the Streaming
Processor page. The intent is to guide users further in what token
stealing is, why it happens, when it happens, and what the consequence
may be to them.

#288
Add missing link to UnitOfWork

#288
Replace command sample for third-party service, as command dispatching
would only occur again in a distributed scenario. Although defining this
 wouldn't be off, it's out of the scope of the intent of the enumartion.

#288
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Append `RevisionSnapshotFilter` description to Filtering Snapshot Events sub-section
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
smcvb and others added 10 commits November 4, 2022 10:47
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Co-authored-by: Sara Torrey <sara.torrey@axoniq.io>
Replace ascertain for guarantee for simplicity in language use.

#288
Add 4.6.2 release notes
Add notices on Dead-Letter Queue support for Sagas
[#288] Add Token Stealing subsection to Tracking Tokens
Fine tune code samples for DLQ configuration

#287
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence I'm approving this pull request.

@smcvb smcvb merged commit 0d1b7dc into master Nov 8, 2022
@smcvb smcvb deleted the dead-letter-example-code branch November 8, 2022 10:13
smcvb added a commit that referenced this pull request Nov 8, 2022
Fine tune code samples for DLQ configuration

#287

(cherry picked from commit b4d7c16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation regarding Spring Boot AutoConfiguration for Dead-Letter Processors does not work

4 participants