Skip to content

Conversation

@gablans
Copy link

@gablans gablans commented Aug 13, 2025

Purpose

Add brand new support from preview.2 for chaptering. This is the first example.

  • ...

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

New Python Notebook, analyzer, utilities for review. Will provide updates incrementally

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Go through the notebook!

@gablans gablans requested a review from rsmenezes August 13, 2025 06:36

# Environments
.env
/.env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required? The main README.md asks user to put the .env in notebooks/ dir, so we should not enforce this to be at /.env

@@ -0,0 +1,58 @@
{
"description": "test model",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better description for the mode.

@@ -0,0 +1,58 @@
{
"description": "test model",
"scenario": "videoShot",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as it's only for Preview.1.

"config": {
"returnDetails": true,
"enableSegmentation": true,
"enableFace": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these two for this sample to work? It seems strange that we have face to be disabled, but we also disable face blurring. These two requires opt-in face and no all users will have this.

"enableSegmentation": true,
"enableFace": false,
"disableFaceBlurring": true,
"disableContentFiltering": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for this sample as not all users have the right to disable content filtering.

},
"BaseAnalyzerId": "prebuilt-videoAnalyzer",
"fieldSchema": {
"name": "Content Understanding",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider remove name and description if they are not used. Or add useful sample to showcase the use.

"type": "object",
"properties": {
"SegmentId": { "type": "string" },
"SegmentType": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an enum and a classify field instead?

"Description": {
"type": "string",
"method": "generate",
"description": "A 5 word description of the scene. A scene is a smaller segment of the segment where a continous block for storytelling unfolds within a specific time, place, and set of characters. A scene can only belong to a single chapter, and cannot overlap with other scenes. Scenes are sequential across the video."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion from copilot for grammar and clarity:

"A five-word description of the scene. A scene is a smaller unit within a segment, representing a continuous block of storytelling that unfolds in a specific time, place, and with a defined set of characters. Each scene belongs to only one chapter and cannot overlap with other scenes. Scenes are arranged sequentially throughout the video."

@chienyuanchang
Copy link
Contributor

#14 is the newer branch and PR. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants