-
Notifications
You must be signed in to change notification settings - Fork 8
Preview.2 support for Structured Video Chapters #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| # Environments | ||
| .env | ||
| /.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required? The main README.md asks user to put the .env in notebooks/ dir, so we should not enforce this to be at /.env
| @@ -0,0 +1,58 @@ | |||
| { | |||
| "description": "test model", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a better description for the mode.
| @@ -0,0 +1,58 @@ | |||
| { | |||
| "description": "test model", | |||
| "scenario": "videoShot", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed as it's only for Preview.1.
| "config": { | ||
| "returnDetails": true, | ||
| "enableSegmentation": true, | ||
| "enableFace": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these two for this sample to work? It seems strange that we have face to be disabled, but we also disable face blurring. These two requires opt-in face and no all users will have this.
| "enableSegmentation": true, | ||
| "enableFace": false, | ||
| "disableFaceBlurring": true, | ||
| "disableContentFiltering": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this for this sample as not all users have the right to disable content filtering.
| }, | ||
| "BaseAnalyzerId": "prebuilt-videoAnalyzer", | ||
| "fieldSchema": { | ||
| "name": "Content Understanding", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider remove name and description if they are not used. Or add useful sample to showcase the use.
| "type": "object", | ||
| "properties": { | ||
| "SegmentId": { "type": "string" }, | ||
| "SegmentType": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an enum and a classify field instead?
| "Description": { | ||
| "type": "string", | ||
| "method": "generate", | ||
| "description": "A 5 word description of the scene. A scene is a smaller segment of the segment where a continous block for storytelling unfolds within a specific time, place, and set of characters. A scene can only belong to a single chapter, and cannot overlap with other scenes. Scenes are sequential across the video." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion from copilot for grammar and clarity:
"A five-word description of the scene. A scene is a smaller unit within a segment, representing a continuous block of storytelling that unfolds in a specific time, place, and with a defined set of characters. Each scene belongs to only one chapter and cannot overlap with other scenes. Scenes are arranged sequentially throughout the video."
Introducing Structured and Dynamic Video Chapters. Cleanup to follow
|
#14 is the newer branch and PR. Closing this PR. |
Purpose
Add brand new support from preview.2 for chaptering. This is the first example.
Does this introduce a breaking change?
Pull Request Type
New Python Notebook, analyzer, utilities for review. Will provide updates incrementally
How to Test
Go through the notebook!