This repository was archived by the owner on Feb 27, 2024. It is now read-only.
[GTD][Code Sample] React SPA Code Sample Update (ADO-54223) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
henrymbuguakiarie
left a comment
henrymbuguakiarie
left a comment
There was a problem hiding this comment.
Hello @OwenRichards1, the codes works perfectly fine. I have point some instance where are importing context that we are not using. Otherswise, LGTM.
src/index.js
Outdated
| @@ -1,104 +1,32 @@ | |||
| import React, { useState } from 'react'; | |||
Contributor
There was a problem hiding this comment.
We import {useState} but it's never used.
src/index.js
Outdated
| import { Configuration, PublicClientApplication } from "@azure/msal-browser"; | ||
| import { MsalProvider, useMsal, useIsAuthenticated } from "@azure/msal-react"; | ||
| // </ms_docref_import_modules> | ||
| import { Configuration, PublicClientApplication } from '@azure/msal-browser'; |
Contributor
There was a problem hiding this comment.
We import {Configuration} but it's never used.
src/index.js
Outdated
| import { MsalProvider, useMsal, useIsAuthenticated } from "@azure/msal-react"; | ||
| // </ms_docref_import_modules> | ||
| import { Configuration, PublicClientApplication } from '@azure/msal-browser'; | ||
| import { MsalProvider, useMsal, useIsAuthenticated } from '@azure/msal-react'; |
Contributor
There was a problem hiding this comment.
We import {useMsal, useIsAuthenticated} but we never use them in this file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@henrymbuguakiarie please verify this is correct, pretty sure I have done this correctly.
@cilwerner @Dickson-Mwendia