updated sample #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

derisen merged 15 commits into main from basher-1-1

Nov 29, 2022

Contributor

salman90 commented Nov 11, 2022 •

edited

Loading

Pull Request

Purpose

Update the following:

Readme.
PowerShell scripts.
Update logout function.
Msal-browser.

Thanks for your time.

Does this introduce a breaking change

    [ x ] Yes
    [ ] No

Pull request type

What kind of change does this Pull Request introduce?

    [  x ] Bugfix
    [ ] Feature
    [ x ] Code style update (formatting, local variables)
    [ x ] Documentation content changes
    [ ] Other... Please describe:

How to test

Get the code

    git clone [repo-address]
    cd [repo-name]
    git checkout [branch-name]
    npm install

Test the code

What to check

ex: verify that the following are valid:

...

Other Information


          updated sample 1-1

21aa284

salman90 requested review from aremo-ms, derisen, kalyankrishna1 and v-michaelmi

November 11, 2022 02:16

github-advanced-security bot found potential problems

View reviewed changes

1-Authentication/1-sign-in/server.js Fixed Show fixed Hide fixed

salman90 requested a review from tonyYuhaoYangMcrS

November 11, 2022 02:18

salman90 marked this pull request as draft

November 11, 2022 02:54

salman90 added 5 commits

November 16, 2022 14:51


          updated bootstrap and added retelimit

1ff64ec


          Merge branch 'main' into basher-1-1

9535ec0


          update config file

d289f6e


          Merge branch 'basher-1-1' of https://github.com/Azure-Samples/ms-iden…

78831e1

…tity-javascript-tutorial into basher-1-1


          fix conflect

a517bc5

salman90 marked this pull request as ready for review

November 16, 2022 23:14

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/App/authConfig.js Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/App/authConfig.js Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/App/authPopup.js Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/README.md Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/README.md Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/README.md Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/server.js Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/README.md Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/App/authConfig.js Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/AppCreationScripts/sample.json Outdated Show resolved Hide resolved

Contributor

derisen commented Nov 17, 2022

@salman90 can we also add account switcher to all sign-in samples?


          Minor updates

d6973ae

kalyankrishna1 reviewed

View reviewed changes

1-Authentication/1-sign-in/AppCreationScripts/sample.json Show resolved Hide resolved

kalyankrishna1 approved these changes

View reviewed changes

Contributor

kalyankrishna1 left a comment

salman90 and others added 2 commits

November 17, 2022 16:06


          Update 1-Authentication/1-sign-in/App/authConfig.js

c1525dd

Update path

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>


          Update 1-Authentication/1-sign-in/App/authConfig.js

60428fd

Update path

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>

salman90 and others added 5 commits

November 17, 2022 16:08


          Update 1-Authentication/1-sign-in/README.md

2b67208

redirect

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>


          Update 1-Authentication/1-sign-in/README.md

0de9b79

white space

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>


          Update 1-Authentication/1-sign-in/server.js

ddbd59f

white space in express

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>


          Update 1-Authentication/1-sign-in/AppCreationScripts/sample.json

d25c9a5

updated redirect in sample.json

Co-authored-by: Doğan Erişen <dogan.erisen@gmail.com>


          responded to comments

3b995b0

salman90 requested a review from derisen

November 18, 2022 22:31

derisen reviewed

View reviewed changes

1-Authentication/1-sign-in/server.js Outdated Show resolved Hide resolved

Contributor

derisen commented Nov 28, 2022

@salman90 could you also fix the failing CI in this PR?


          add redirect.html to app and update pacakges

c1956b6

Contributor Author

salman90 commented Nov 29, 2022

@salman90 could you also fix the failing CI in this PR?

Done!

derisen merged commit fc50768 into main

derisen deleted the basher-1-1 branch

December 7, 2022 22:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

v-michaelmi Awaiting requested review from v-michaelmi

aremo-ms Awaiting requested review from aremo-ms

tonyYuhaoYangMcrS Awaiting requested review from tonyYuhaoYangMcrS

2 more reviewers

derisen derisen left review comments

kalyankrishna1 kalyankrishna1 approved these changes

Labels

None yet