Skip to content

Added Customer Usage Attribute - Cleaned up unneeded files, updated ReadMe with opt out instructions. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2025
Merged

Added Customer Usage Attribute - Cleaned up unneeded files, updated ReadMe with opt out instructions. #39

merged 10 commits into from
Mar 6, 2025

Conversation

@MarkAnthFarr
Copy link
Contributor

@MarkAnthFarr MarkAnthFarr commented Mar 6, 2025

Purpose

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ x] Other... Please describe: Usage tracking for reporting.

How to Test

  • Get the code
Follow deployment instructions in README
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

ckittel
ckittel requested changes Mar 6, 2025
View reviewed changes
infra-as-code/bicep/customerUsageAttribution/README.md Outdated
Copy link
Member

@ckittel ckittel Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Copy link
Contributor Author

@MarkAnthFarr MarkAnthFarr Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete

MarkAnthFarr and others added 7 commits March 6, 2025 16:10
@MarkAnthFarr
Delete infra-as-code/bicep/customerUsageAttribution/README.md
7060495 
File not needed
@MarkAnthFarr @ckittel
Update README.md
3fbff90 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@MarkAnthFarr @ckittel
Update infra-as-code/bicep/customerUsageAttribution/cuaIdResourceGrou…
da136c0 
…p.bicep

Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@MarkAnthFarr @ckittel
Update infra-as-code/bicep/main.bicep
81b126d 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@MarkAnthFarr @ckittel
Update infra-as-code/bicep/main.bicep
bea4a12 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@MarkAnthFarr @ckittel
Update infra-as-code/bicep/main.bicep
0afe050 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@MarkAnthFarr @ckittel
Update infra-as-code/bicep/main.bicep
c9d8fbf 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel
ckittel approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ckittel ckittel merged commit 5512fbf into Azure-Samples:main Mar 6, 2025
1 check passed
@ckittel ckittel mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckittel ckittel ckittel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarkAnthFarr @ckittel @MarkFarr-MS