-
Notifications
You must be signed in to change notification settings - Fork 618
Improvements and Tests #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psycopg2-binary is required by create_engine for postgresql database in setting up the tests
There is no need to do a full installation to use ruff this will make the workflow faster
this also improves the swagger api examples as it's typed now
…e 100% for frontend routes
john0isaac
commented
Jun 28, 2024
john0isaac
commented
Jun 28, 2024
john0isaac
commented
Jun 28, 2024
john0isaac
commented
Jun 28, 2024
john0isaac
commented
Jun 28, 2024
john0isaac
commented
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR sets up two test clients one with the database and one without. It also adds data classes for the response that follows the Microsoft Chat Protocol and improves the typing. It also adds tests for the frontend routes with 100% coverage.
Does this introduce a breaking change?
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest).python -m pytest --covto verify 100% coverage of added linespython -m mypyto check for type errorsruffmanually on my code.