Skip to content

Conversation

@john0isaac
Copy link
Contributor

Purpose

This PR sets up two test clients one with the database and one without. It also adds data classes for the response that follows the Microsoft Chat Protocol and improves the typing. It also adds tests for the frontend routes with 100% coverage.

image

Does this introduce a breaking change?

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

psycopg2-binary is required by create_engine for postgresql database in setting up the tests
There is no need to do a full installation to use ruff this will make the workflow faster
this also improves the swagger api examples as it's typed now
@john0isaac john0isaac deleted the branch Azure-Samples:main June 29, 2024 12:25
@john0isaac john0isaac closed this Jun 29, 2024
@john0isaac john0isaac deleted the main branch June 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant