Change storage blob track1 to track2 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jongio - Can you help ping the corresponding person to review this PR? |
|
@scottaddie, @AlexGhiondea, @kyle-patterson , @tg-msft, @amishra-dev - Could you help review this PR? |
tg-msft
reviewed
Aug 31, 2021
| // to allow public access to blobs in this container. Comment the line below to not use this approach and to use SAS. Then you can view the image | ||
| // using: https://[InsertYourStorageAccountNameHere].blob.core.windows.net/webappstoragedotnet-imagecontainer/FileName | ||
| await blobContainer.SetPermissionsAsync(new BlobContainerPermissions { PublicAccess = BlobContainerPublicAccessType.Blob }); | ||
| await blobContainer.SetAccessPolicyAsync(PublicAccessType.Blob); |
There was a problem hiding this comment.
Let's just pass PublicAccessType.Blob into CreateIfNotExistsAsync. It'll teach people better patterns.
Comment on lines
79
to
82
| string a = blobContainer.Uri.ToString(); | ||
| if (blob.Properties.BlobType == BlobType.Block) | ||
| allBlobs.Add(new Uri(blobContainer.Uri.ToString()+"/"+blob.Name)); | ||
| } |
There was a problem hiding this comment.
Do blobContainer.GetBlob(blob.Name).Uri instead of all this.
|
@tg-msft We have updated, please re-review this PR. |
tg-msft
approved these changes
Sep 13, 2021
|
@tg-msft Could you please help merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change storage blob track1 to track2