Skip to content

Conversation

@wanghoppe
Copy link
Member

No description provided.

@wanghoppe wanghoppe marked this pull request as ready for review June 7, 2024 17:37
@dpwatrous
Copy link
Member

/azp run BatchExplorer - CI

@codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (dbb67f0) to head (d95176c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2912   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        1262     1262           
  Lines       34257    34257           
  Branches     6303     6303           
=======================================
  Hits        23124    23124           
  Misses      10963    10963           
  Partials      170      170           
Files Coverage Δ
packages/service/src/constants.ts 100.00% <ø> (ø)
packages/service/src/internal/batch-rest/client.ts 85.71% <ø> (ø)
...ice/src/internal/batch-rest/generated/src/index.ts 100.00% <100.00%> (ø)
.../internal/batch-rest/generated/src/isUnexpected.ts 87.17% <ø> (ø)
...nternal/batch-rest/generated/src/paginateHelper.ts 68.75% <ø> (ø)
...c/internal/batch-rest/generated/src/batchClient.ts 70.00% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb67f0...d95176c. Read the comment docs.

@dpwatrous
Copy link
Member

Looks good to me, let's just make sure to remove the Typescript/Angular kludge when we're able to update Angular.

@wanghoppe wanghoppe merged commit 3d97364 into main Jun 24, 2024
@wanghoppe wanghoppe deleted the hoppe/update-tsp branch June 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants