Skip to content

Conversation

@andrew-eldridge
Copy link
Contributor

@andrew-eldridge andrew-eldridge commented Oct 8, 2025

Cherry-pick of the following PR #8350
Fixes #8354, #8355

temporarily remove validatePartial, startRuntimeApi on open designer as mitigation

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Cherry-pick designer issue mitigations to hotfix branch

Impact of Change

  • Users: Mitigation for issues blocking opening designer and launching debugger
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

…itigate designer issues (Azure#8350)

temporarily remove validatePartial, startRuntimeApi on open designer as mitigation
@andrew-eldridge andrew-eldridge added VSCode Issues or PRs specific to VS Code extension Risk:Medium Medium risk change with potential impact bug Something isn't working labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Temporarily remove validatePartial, startRuntimeApi to mitigate designer issues
  • Issue: Title is clear, scoped, and expresses what is being changed and why
  • Recommendation: No changes needed

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Risk level marked as "Medium" in both body and label, matches the impact of code (removes validation/runtime features temporarily for mitigation)

What & Why

  • Current: Cherry-pick designer issue mitigations to hotfix branch
  • Issue: Concise and relevant
  • Recommendation: Optionally specify affected designer flows, but the summary is sufficient

Impact of Change

  • User impact: Mitigates issues blocking designer and debugger launch
  • Developers impact: Marked N/A (acceptable)
  • System impact: Marked N/A (acceptable)
  • Recommendation: No required edits. For best practice, briefly mention which designer scenarios could fail or behave differently, e.g., validation omitted temporarily, runtime behavior affected.

Test Plan

  • Manual testing completed; Unit/E2E not applicable for hotfix mitigation

⚠️ Contributors

  • Only @andrew-eldridge listed
  • Recommendation: Consider tagging any PMs, Designers, or reviewers who contributed to the solution or original idea.

Screenshots/Videos

  • Not needed, none included—no clear evidence it is a visual-only change

Summary Table

Section Status Recommendation
Title
Commit Type
Risk Level
What & Why Optionally specify exact designer impacts
Impact of Change Optionally clarify affected scenarios
Test Plan
Contributors ⚠️ Optional: credit more contributors if applicable
Screenshots/Videos

PR passes all required sections. Please optionally enhance contributor acknowledgement and consider specifying exact scenarios impacted if you want to improve traceability. Thank you for helping maintain high-quality documentation for your team!


Last updated: Thu, 09 Oct 2025 21:25:56 GMT

@ccastrotrejo ccastrotrejo changed the title fix(vscode): [Cherry-pick] temporarily remove validatePartial, startRuntimeApi to m… fix(vscode): Temporarily remove validatePartial, startRuntimeApi to mitigate designer issues Oct 8, 2025
@andrew-eldridge andrew-eldridge enabled auto-merge (squash) October 8, 2025 17:28
@andrew-eldridge andrew-eldridge merged commit 82a593c into Azure:hotfix/v5.185 Oct 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pr-validated Risk:Medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants