Skip to content

Conversation

@ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Oct 17, 2025

Cherry-pick of the following PR - #8368

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Windows 11 installations have removed wmic by default. We were using ps-tree which had wmic as a dependency and caused vscode users to be unable to open designer. We have removed the dependency on ps-tree by using powershell to find the child func process. Permanent fix for #8349

Impact of Change

  • Users: Users should no longer need to install WMIC manually in order to get vscode designer working on Windows.
  • Developers:
  • System:

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Windows 11 with and without WMIC installed.

Contributors

@ccastrotrejo @lambrianmsft

Screenshots/Videos

…prcess (#8368)

Migrated from ps-tree to using powershell to find child prcess
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Migrated from ps-tree to using powershell to find childprocess
  • Issue: Title is clear and specific. It includes the affected area (vscode), describes the change (migration from ps-tree to powershell), and context (finding childprocess).
  • Recommendation: No changes needed.

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Commit body and label both specify Medium risk. Estimation is accurate based on the dependency shift and direct user impact.

What & Why

  • Current: Windows 11 installations have removed wmic by default. We were using ps-tree which had wmic as a dependency and caused vscode users to be unable to open designer. We have removed the dependency on ps-tree by using powershell to find the child func process. Permanent fix for Unable to open Designer with 5.185.8 #8349
  • Issue: Brief and relevant context provided.
  • Recommendation: No action needed.

Impact of Change

  • Clearly identifies user impact: Users should no longer need to install WMIC manually.
  • Developers/Sys impact: Describes dependency removal and new approach.
  • Recommendation: If possible, elaborate on developer and system-side impacts for future PRs.

Test Plan

  • Manual testing completed and details provided.
  • Unit/E2E not checked, but manual testing described as sufficient due to the nature of the fix.

⚠️ Contributors

  • Contributors are tagged and present.
  • If other PMs or designers contributed, add them for credit next time.

Screenshots/Videos

  • No visual changes, so screenshots/videos not required.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change Consider slightly expanding developer/system impact
Test Plan None
Contributors ⚠️ Add PM/Design credit if they contributed
Screenshots/Videos Not required

Everything required in your PR title and body is present and properly formatted. Please consider minor improvements to Impact and Contributors for future submissions. Thank you for helping maintain high-quality documentation for your team!


Last updated: Fri, 17 Oct 2025 18:02:44 GMT

@ccastrotrejo ccastrotrejo changed the title fix(vscode): Migrated from ps-tree to using powershell to find childprcess fix(vscode): Migrated from ps-tree to using powershell to find childprocess Oct 17, 2025
@ccastrotrejo ccastrotrejo added the Risk:Medium Medium risk change with potential impact label Oct 17, 2025
@ccastrotrejo ccastrotrejo enabled auto-merge (squash) October 17, 2025 18:13
@ccastrotrejo ccastrotrejo merged commit ddb17cf into hotfix/v5.185 Oct 17, 2025
9 of 12 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/fixPSTree branch October 17, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated Risk:Medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants