FIX: Fixing Scorer Memory Add and Validate #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashirpartovi
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Thanks for fixing this @rlundeen2 , looks good to me, just a minor comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several scorers were not adding scores to memory or validating during score_async. Amongst other things, this was causing a failure in our "sending a million prompts" cookbook because the composite scorer was not adding the score to memory.
This change centralizes that operation so that validate and memory addition are called in the base class, and the _score_async is now the abstract method.