Skip to content

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jan 29, 2023

Regen: Azure/azure-sdk-for-net#33745

Description

This PR adds a new configuration to allow you to mark a specific request path as a "scope" with a certain resource type.

For more details about this, please check the new doc changes in this PR.

This PR also fixes a using issue when the samples invoke the extension methods (added the missing using statement)

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review January 30, 2023 02:19
@ArcturusZhang ArcturusZhang enabled auto-merge (squash) February 2, 2023 07:03
@ArcturusZhang ArcturusZhang merged commit a523406 into Azure:feature/v3 Feb 3, 2023
@ArcturusZhang ArcturusZhang deleted the add-a-new-configuration-to-convert-things-to-scope branch February 3, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants