Skip to content

upgrade cadl to 0.39 #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 1, 2023
Merged

upgrade cadl to 0.39 #3046

merged 13 commits into from
Feb 1, 2023

Conversation

@chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Jan 31, 2023 •
edited
Loading

Description

Fix #3045

  • upgrade cadl to 0.39
  • resolve issue: base model is not generated

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

pshao25
pshao25 reviewed Feb 1, 2023
View reviewed changes
@chunyu3 chunyu3 requested a review from allenjzhang as a code owner February 1, 2023 05:52
@chunyu3 chunyu3 enabled auto-merge (squash) February 1, 2023 05:52
@chunyu3 chunyu3 disabled auto-merge February 1, 2023 05:53
@chunyu3 chunyu3 merged commit 160f7d4 into Azure:feature/v3 Feb 1, 2023
@ArcturusZhang ArcturusZhang mentioned this pull request Mar 6, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lirenhe lirenhe lirenhe approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@pshao25 pshao25 pshao25 approved these changes

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

@m-nash m-nash Awaiting requested review from m-nash

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

+1 more reviewer

@archerzz archerzz archerzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base Model is not generated

5 participants

@chunyu3 @archerzz @lirenhe @ArcturusZhang @pshao25