Skip to content

Fix parameter mapping for provider namespace #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Fix parameter mapping for provider namespace #3070

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f261d16
fix parameter mapping for provider namespace
fengzhou-msft Feb 3, 2023
d0b9c13
Merge branch 'feature/v3' of github.com:Azure/autorest.csharp into fi…
fengzhou-msft Feb 3, 2023
53e418b
Merge branch 'feature/v3' into fix_namespace_parameter_mapping
fengzhou-msft Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/AutoRest.CSharp/Mgmt/Decorator/ParameterMappingBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ private static void BuildContextualParameterMappingHierarchy(RequestPath current
// get the segment in pairs
var segmentPairs = SplitDiffIntoPairs(diffPath).ToList();
var indexOfProvidersPair = segmentPairs.FindIndex(pair => pair[0] == Segment.Providers);
var resourceTypeIdVariableName = idVariableName;
// from the tail, check these segments in pairs
for (int i = 0; i < segmentPairs.Count; i++)
{
Expand All @@ -99,7 +100,7 @@ private static void BuildContextualParameterMappingHierarchy(RequestPath current
}
else
{
parameterMappingStack.Push(new ContextualParameterMapping(keySegment.ConstantValue, valueSegment, $"{idVariableName}.ResourceType.Namespace"));
parameterMappingStack.Push(new ContextualParameterMapping(keySegment.ConstantValue, valueSegment, $"{resourceTypeIdVariableName}.ResourceType.Namespace"));
}
// do not append a new .Parent to the id
}
Expand All @@ -120,6 +121,7 @@ private static void BuildContextualParameterMappingHierarchy(RequestPath current
if (keySegment.IsReference)
{
parameterMappingStack.Push(new ContextualParameterMapping(string.Empty, keySegment, $"{idVariableName}{invocationSuffix}.ResourceType.GetLastType()", new[] { "System.Linq" }));
resourceTypeIdVariableName = $"{idVariableName}{invocationSuffix}";
appendParent = true;
}
else if (keySegment.IsExpandable)
Expand Down