Skip to content

Fix issue with genereic list resolution for existing types #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fix issue with genereic list resolution for existing types #3072

merged 1 commit into from
Feb 3, 2023

Conversation

@m-nash
Copy link
Member

@m-nash m-nash commented Feb 3, 2023

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash m-nash requested a review from allenjzhang as a code owner February 3, 2023 22:06
JoshLove-msft
JoshLove-msft approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@AlexanderSher AlexanderSher merged commit 02a21ad into feature/v3 Feb 3, 2023
@AlexanderSher AlexanderSher deleted the mnash-fixExistingTypes branch February 3, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-nash @JoshLove-msft @AlexanderSher