Skip to content

fix(emitter): filter out api versions not specified by api-version #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2024
Merged

fix(emitter): filter out api versions not specified by api-version #4776

merged 5 commits into from
May 28, 2024

Conversation

@archerzz
Copy link
Member

@archerzz archerzz commented May 28, 2024

Description

  • add logic to filter out api versions newer than specified api-version
  • add unit tests
  • regen

fix #4775

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

fix(emitter): filter out api versions not specified by api-version
9edb262 
- add logic to filter out api versions newer than specified `api-version`
- add unit tests
- regen

fix Azure#4775
@archerzz archerzz added bug This issue requires a change to an existing behavior in the product in order to be resolved. DPG DPG/RLC v2.1 Post Gallium work labels May 28, 2024
chunyu3
chunyu3 reviewed May 28, 2024
View reviewed changes
@azure-sdk azure-sdk mentioned this pull request May 28, 2024
Closed
@archerzz
Copy link
Member Author

archerzz commented May 28, 2024 •
edited
Loading

Since we'll get available API versions from TCGC probably SdkPackage, I resolved the comments by applying the suggested changes.

@archerzz archerzz merged commit 6116c5c into Azure:feature/v3 May 28, 2024
@archerzz archerzz deleted the emitter/filter-out-api-versions branch May 28, 2024 08:14
@archerzz archerzz restored the emitter/filter-out-api-versions branch May 28, 2024 08:14
@archerzz archerzz deleted the emitter/filter-out-api-versions branch May 28, 2024 08:14
archerzz added a commit to archerzz/typespec that referenced this pull request May 31, 2024
@archerzz
fix(emitter): filter out api versions not specified by api-version
9ad0d58 
This is a port of Azure/autorest.csharp#4776
@archerzz archerzz mentioned this pull request May 31, 2024
Merged
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jun 3, 2024
@archerzz @ArcturusZhang
fix(emitter): filter out api versions not specified by api-version (#…
405addf 
…3489)

This is a port of Azure/autorest.csharp#4776

Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunyu3 chunyu3 chunyu3 approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@lirenhe lirenhe Awaiting requested review from lirenhe

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@hallipr hallipr Awaiting requested review from hallipr

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft

Assignees

No one assigned

Labels

bug This issue requires a change to an existing behavior in the product in order to be resolved. DPG/RLC v2.1 Post Gallium work DPG

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(dpg): some api versions should be ignored when api-version is specified

2 participants

@archerzz @chunyu3