Wrong command name when `All` is present in an API path

[peombwa]

When an API path such as /teams/{team-id}/allChannels contains All, AutoREST.PowerShell drops the All in the resultant command name - Get-TeamChannel. This causes conflicts with API paths such as /teams/{team-id}/Channels, as we end up generating a single command (Get-TeamChannel) that calls two different APIs with the same parameter set.

[dolauli]

@peombwa Would you post the operationId used in swagger for these two API?

[peombwa]

@dolauli, the operationIds are teams_GetAllChannels for /teams/{team-id}/allChannels and teams_GetChannels for /teams/{team-id}/Channels. Here is an excerpt of the paths from the swagger document:

  '/teams/{team-id}/allChannels/{channel-id}':
    get:
      tags:
        - teams.channel
      summary: Get allChannels from teams
      operationId: teams_GetAllChannels
      parameters:
        - name: team-id
          in: path
          description: 'key: id of team'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: team
        - name: channel-id
          in: path
          description: 'key: id of channel'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: channel
      responses:
        '200':
          description: Retrieved navigation property
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/microsoft.graph.channel'
        default:
          $ref: '#/components/responses/error'
      x-ms-docs-operation-type: operation
  '/teams/{team-id}/channels/{channel-id}':
    get:
      tags:
        - teams.channel
      summary: Get channels from teams
      operationId: teams_GetChannels
      parameters:
        - name: team-id
          in: path
          description: 'key: id of team'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: team
        - name: channel-id
          in: path
          description: 'key: id of channel'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: channel
      responses:
        '200':
          description: Retrieved navigation property
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/microsoft.graph.channel'
        default:
          $ref: '#/components/responses/error'
      x-ms-docs-operation-type: operation
  '/teams/{team-id}/allChannels':
    get:
      tags:
        - teams.channel
      summary: Get allChannels from teams
      operationId: teams_ListAllChannels
      parameters:
        - name: team-id
          in: path
          description: 'key: id of team'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: team
      responses:
        '200':
          $ref: '#/components/responses/microsoft.graph.channelCollectionResponse'
        default:
          $ref: '#/components/responses/error'
      x-ms-docs-operation-type: operation
  '/teams/{team-id}/channels':
    get:
      tags:
        - teams.channel
      summary: Get channels from teams
      operationId: teams_ListChannels
      parameters:
        - name: team-id
          in: path
          description: 'key: id of team'
          required: true
          schema:
            type: string
          x-ms-docs-key-type: team
      responses:
        '200':
          $ref: '#/components/responses/microsoft.graph.channelCollectionResponse'
        default:
          $ref: '#/components/responses/error'
      x-ms-docs-operation-type: operation

[dolauli]

We expect the operationID is [group]_[operation]. There is a logic here in autorest.powershell to remove all from the operation. And back to your case, allchannels and channels are two different resource type actually, so they should not be grouped into one cmdlet. There are two ways, I suggested.

1. Change the operationId, e.g. teams_GetAllChannels to teamsAllChannels_Get
2. Rename cmdlet through directive for allchannel related cmdlets