Fix double quote in string pattern #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
force-pushed
the
fixDoubleQuoteInPattern
branch
from
6b7d8ad to
936db48
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dolauli
reviewed
Jun 6, 2023
powershell/llcsharp/schema/string.ts
Outdated
| } | ||
| private validateRegex(eventListener: Variable, property: Variable): string { | ||
| const pattern = (<any>this.schema).pattern; | ||
| const pattern = (<any>this.schema).pattern?.replace('"', '""'); |
Contributor
There was a problem hiding this comment.
Is it possible that there are more than one double quote in pattern? Changing to replace(/"/g, '""') may be better.
BethanyZhou
commented
Jun 7, 2023
VeryEarly
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Fix double quote in string pattern * Update powershell/llcsharp/schema/string.ts
dolauli
added a commit
that referenced
this pull request
Jun 28, 2023
* putOperation['requestMediaTypes']['application/json'].parameters.find * generate variants for update(get+put) * generate call method with result * generate client methods with result * decouple class.ts a little bit * more refactoring * more refactoring * more refactoring * fix * more refactor, generate get+put * bugfix * set body parameter all optional for get put * resolve conflict with bc04a21 * resolve conflict with 96e95ea * resolve conflict with f0a3b20 * v4 - Fixed an issue wrt the name conflict (#1165) * Remove complex interface information from help markdown (#1164) * resolve conflict with 0bc76c3 * v4 - Inherited internal property should be internal instead of public (#1167) * v4 - Polymorphic member should be public in a model (#1168) * Update test-module.ps1 to enable exit (#1170) * v4 - only singulize the last word in the group (#1172) * v4 - remove duplicated word in group (#1169) * Fixed two minor issues - single quote related and uri.tostring related (#953) * Fixed two minor issues - single quote related and uri.tostring related * Revert the change * Escape angle brackets for placeholders (#958) * Escape angle brackets for placeholders * Use Backticks to escape Co-authored-by: Timothy Wamalwa <twamalwa@microsoft.com> Co-authored-by: Xiaogang <xidi@microsoft.com> * resolve conflict with 7483af5 * Quote prerelease version. (#977) * Deserialize enum responses. (#1010) * Update directives.md (#1101) * Add warning message for -DefaultProfile (#1128) * Add warning message for -DefaultProfile and clean model cmdlet folder when regenerate * Use PSVersionTable.PSVersion for PowerShell versio * Fix double quote in string pattern (#1171) * Fix double quote in string pattern * Update powershell/llcsharp/schema/string.ts * v4 - update some dependencies (#1176) * Fix date issue in URL (#1177) * resolve conflict with 2a461a1 * v4 - update @autorest/extension-base to 3.5.2 and fixed issues caused by breaking changes (#1179) * resolve conflict with 9d511a9 * Keep consistent GUID after updating psd1. Fixed issues [#981] (#1181) * fix bug in resolve response type * fix resolve type * add missing yield * also compare exceptions in get response with put reqeusts * adjust parameters order when invoke client method * bugfix * fix serialization mode * fix OperationType for Set cmdlets * add flag to disable Get+Put * adjust parameters order for client methods * adjust parameters order for client methods with header parameters added * enable GET+PUT only for azure services * adjust parameters order while invoking client methods * resolve some comments * bugfix * match path for all get operations, edit virtual properties required in plugin vreate inline properties * bugfix * Update create-commands-v2.ts to fix a minor issue * minor fix * revert OperationType update for Set cmdlet * fix variable name * bugfix: GET+PUT get only accept path parameters * do not generate GET+PUT when GET has query parameters * bugfix * adjust parameters order while invoking client methods --------- Co-authored-by: Beisi Zhou <zazbs@qq.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Xiaogang <xidi@microsoft.com> Co-authored-by: Tim <timwamalwa@gmail.com> Co-authored-by: Timothy Wamalwa <twamalwa@microsoft.com> Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.