Emit Signal method and delegate to provide a hook into events #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @dolauli would it be possible to get this reviewed an merged. These additional hooks will allow us to implement a proper -debug feature in our Microsoft Graph PowerShell. Thanks! |
dolauli
reviewed
Jun 23, 2020
dolauli
requested changes
Jun 23, 2020
Contributor
dolauli
left a comment
dolauli
left a comment
There was a problem hiding this comment.
Minor changes are required.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit Signal method in non Azure Modules, to allow us to hook into event system for cross cutting concerns such as logging HTTP Requests/Responses when -Debug parameter is specified.
Call Init() in the Module private constructor to light up the CustomInit() pattern.