Adding target attribute to nuspec file elements #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolauli
reviewed
Jun 24, 2020
Contributor
dolauli
left a comment
dolauli
left a comment
There was a problem hiding this comment.
The change will fix the issue in Mac, but will fail packaging (create another level of folder, e.g. internal/internal/, custom/custom/) in Windows. So I have to reject this change.
Author
|
Apologies, I didn't think to double check Windows. I'll look to make this work cross platform, microsoft/dotnet#1208 might have some clues |
Author
|
I'm getting the same file listing when generating the package under Windows, OS X and Ubuntu with the latest change |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OS X
pack-module.ps1is including the content of custom/docs/exports/internal in the top level of the generated .nupkg rather than maintaining the directory structure.Based on https://docs.microsoft.com/en-us/nuget/reference/nuspec#including-assembly-files a target attribute is required to ensure the correct structure is achieved