Skip to content

Fixed a completer related issue and add support for credential #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Fixed a completer related issue and add support for credential #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4f1f0b
Add databricks, fix several issues
dolauli Aug 10, 2020
3fb09fe
Merge branch 'modelerfour' into test
dolauli Aug 10, 2020
05e078c
Fixed a completer related issue and add support for credential
dolauli Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions powershell/cmdlets/class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2469,7 +2469,7 @@ export class NewCmdletClass extends Class {
}

const isEnum = propertyType.schema.language.csharp?.enum !== undefined;
const hasEnum = propertyType instanceof ArrayOf && propertyType.elementType instanceof NewEnumImplementation;
const hasEnum = propertyType instanceof NewArrayOf && propertyType.elementType instanceof NewEnumImplementation;
if (isEnum || hasEnum) {
cmdletParameter.add(new Attribute(ArgumentCompleterAttribute, { parameters: [`typeof(${hasEnum ? (<NewArrayOf>propertyType).elementType.declaration : propertyType.declaration})`] }));
}
Expand Down Expand Up @@ -2614,7 +2614,7 @@ export class NewCmdletClass extends Class {
}

const isEnum = propertyType.schema.language.csharp?.enum !== undefined;
const hasEnum = propertyType instanceof ArrayOf && propertyType.elementType instanceof NewEnumImplementation;
const hasEnum = propertyType instanceof NewArrayOf && propertyType.elementType instanceof NewEnumImplementation;
if (isEnum || hasEnum) {
regularCmdletParameter.add(new Attribute(ArgumentCompleterAttribute, { parameters: [`typeof(${hasEnum ? (<NewArrayOf>propertyType).elementType.declaration : propertyType.declaration})`] }));
}
Expand Down
1 change: 1 addition & 0 deletions powershell/llcsharp/schema/schema-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ export class NewSchemaDefinitionResolver {
return this.add(schema, new NewObjectImplementation(<ObjectSchema>schema));
}
case SchemaType.Time:
case SchemaType.Credential:
case SchemaType.String: {
return new NewString(<StringSchema>schema, required);

Expand Down