Skip to content

Accept TraceContext from host #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2019
Merged

Accept TraceContext from host #244

merged 1 commit into from
Sep 21, 2019

Conversation

@yojagad
Copy link
Contributor

@yojagad yojagad commented Sep 10, 2019

@yojagad yojagad requested review from brettsam, camillemarie, mhoeger and pragnagopa and removed request for camillemarie September 10, 2019 23:26
@yojagad yojagad force-pushed the CorrelationIdFromRuntime branch from 936ca57 to 843cc81 Compare September 12, 2019 02:00
@yojagad yojagad changed the title Accept correlationId(activityId) from host Accept TraceContext from host Sep 13, 2019
@yojagad yojagad requested a review from lmolkova September 13, 2019 00:24
mhoeger
mhoeger suggested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - thanks!

mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger suggested changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes requested

mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger reviewed Sep 20, 2019
View reviewed changes
mhoeger
mhoeger approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!!

@yojagad yojagad force-pushed the CorrelationIdFromRuntime branch from 80f3219 to ee3d1c1 Compare September 21, 2019 01:14
@yojagad yojagad force-pushed the CorrelationIdFromRuntime branch from ee3d1c1 to b8588ed Compare September 21, 2019 01:22
@yojagad yojagad merged commit 4b86dd6 into Azure:dev Sep 21, 2019
@brettsam brettsam mentioned this pull request Dec 2, 2019
Closed
This was referenced May 23, 2021
Open
Open
Open
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettsam brettsam Awaiting requested review from brettsam

@pragnagopa pragnagopa Awaiting requested review from pragnagopa

@lmolkova lmolkova Awaiting requested review from lmolkova

1 more reviewer

@mhoeger mhoeger mhoeger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yojagad @mhoeger