Skip to content

Fixing faulty logic in InstallFunctionAppDependencies and adding unit test #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Francisco-Gamino merged 10 commits into from
Jun 19, 2019
Merged

Fixing faulty logic in InstallFunctionAppDependencies and adding unit test #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
72791b7
Fixing faulty logic in InstallFunctionAppDependencies and refactoring…
Francisco-Gamino Jun 6, 2019
45d770d
Adding unit test to validate the retry logic in InstallFunctionAppDep…
Francisco-Gamino Jun 6, 2019
deb025e
Fixing faulty logic in InstallFunctionAppDependencies and refactoring…
Francisco-Gamino Jun 7, 2019
626c793
Adding unit test to validate the retry logic in InstallFunctionAppDep…
Francisco-Gamino Jun 7, 2019
41b9b1e
Addressing code review comments.
Francisco-Gamino Jun 7, 2019
7bfd8f0
Adding number of attempts to error log. Updating unit test to reflect…
Francisco-Gamino Jun 11, 2019
0730565
Merge branch 'dev' of https://github.com/Azure/azure-functions-powers…
Francisco-Gamino Jun 17, 2019
95ae8e5
Adding logic to dependency manager to fail in the first dependencies …
Francisco-Gamino Jun 19, 2019
61ce5b2
Adding unit test to validate that a function app execution should con…
Francisco-Gamino Jun 19, 2019
90a39c4
Addressing code review comments.
Francisco-Gamino Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 0 additions & 104 deletions src/DependencyManagement/DependencyManagementUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,11 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Net;
using System.Xml;

namespace Microsoft.Azure.Functions.PowerShellWorker.DependencyManagement
{
internal class DependencyManagementUtils
{
// The PowerShellGallery uri to query for the latest module version.
private const string PowerShellGalleryFindPackagesByIdUri = "https://www.powershellgallery.com/api/v2/FindPackagesById()?id=";

/// <summary>
/// Deletes the contents at the given directory.
/// </summary>
Expand Down Expand Up @@ -51,104 +46,5 @@ internal static void EmptyDirectory(string path)
throw new InvalidOperationException(errorMsg);
}
}

/// <summary>
/// Returns the latest module version from the PSGallery for the given module name and major version.
/// </summary>
internal static string GetModuleLatestSupportedVersion(string moduleName, string majorVersion)
{
Uri address = new Uri($"{PowerShellGalleryFindPackagesByIdUri}'{moduleName}'");
int configuredRetries = 3;
int noOfRetries = 1;

string latestVersionForMajorVersion = null;

while (noOfRetries <= configuredRetries)
{
try
{
HttpWebRequest request = WebRequest.Create(address) as HttpWebRequest;
using (HttpWebResponse response = request?.GetResponse() as HttpWebResponse)
{
if (response != null)
{
// Load up the XML response
XmlDocument doc = new XmlDocument();
using (XmlReader reader = XmlReader.Create(response.GetResponseStream()))
{
doc.Load(reader);
}

// Add the namespaces for the gallery xml content
XmlNamespaceManager nsmgr = new XmlNamespaceManager(doc.NameTable);
nsmgr.AddNamespace("ps", "http://www.w3.org/2005/Atom");
nsmgr.AddNamespace("d", "http://schemas.microsoft.com/ado/2007/08/dataservices");
nsmgr.AddNamespace("m", "http://schemas.microsoft.com/ado/2007/08/dataservices/metadata");

// Find the version information
XmlNode root = doc.DocumentElement;
var props = root.SelectNodes("//m:properties/d:Version", nsmgr);
if (props != null && props.Count > 0)
{
for (int i = 0; i < props.Count; i++)
{
if (props[i].FirstChild.Value.StartsWith(majorVersion))
{
latestVersionForMajorVersion = props[i].FirstChild.Value;
}
}
}
break;
}
}
}
catch (Exception ex)
{
WebException webEx = ex as WebException;
if (webEx == null || noOfRetries >= configuredRetries)
{
throw;
}

// Only retry the web exception
if (ShouldRetry(webEx))
{
noOfRetries++;
}
}
}

// If we could not find the latest module version error out.
if (string.IsNullOrEmpty(latestVersionForMajorVersion))
{
var errorMsg = string.Format(PowerShellWorkerStrings.CannotFindModuleVersion, moduleName, majorVersion);
var argException = new ArgumentException(errorMsg);
throw argException;
}

return latestVersionForMajorVersion;
}

/// <summary>
/// Returns true if the given WebException status matches one of the following:
/// SendFailure, ConnectFailure, UnknownError or Timeout.
/// </summary>
private static bool ShouldRetry(WebException webEx)
{
if (webEx == null)
{
return false;
}

if (webEx.Status == WebExceptionStatus.SendFailure ||
webEx.Status == WebExceptionStatus.ConnectFailure ||
webEx.Status == WebExceptionStatus.UnknownError ||
webEx.Status == WebExceptionStatus.Timeout)
{
return true;
}

return false;
}
}
}
Loading